Comments on: javascript nl2br http://luci.criosweb.ro/blog/2007/07/24/javascript-nl2br/ Never discourage anyone who continually makes progress Mon, 05 Jul 2010 07:06:34 +0000 http://wordpress.org/?v=2.9.1 hourly 1 By: Xavi Ivars http://luci.criosweb.ro/blog/2007/07/24/javascript-nl2br/comment-page-1/#comment-74889 Xavi Ivars Wed, 26 May 2010 19:11:10 +0000 http://luci.criosweb.ro/blog/?p=51#comment-74889 I had to add %0A to the regex in order to replace correctly I had to add %0A to the regex in order to replace correctly

]]> By: Lucian Sabo http://luci.criosweb.ro/blog/2007/07/24/javascript-nl2br/comment-page-1/#comment-9322 Lucian Sabo Fri, 25 Apr 2008 05:47:20 +0000 http://luci.criosweb.ro/blog/?p=51#comment-9322 text.replace takes two arguments: needle and replacement string. You have deleted the second parameter. I don' know what you intended, but this: 1. probably causes an error 2. doesn't serves the purpose of nl2br. Nl2Br means replacing new line break (\n,\r\n, \n\r, etc) with the line break HTML tag (br) So your script in the best scenario will strip all line breaks. text.replace takes two arguments: needle and replacement string.
You have deleted the second parameter. I don’ know what you intended, but this:
1. probably causes an error
2. doesn’t serves the purpose of nl2br. Nl2Br means replacing new line break (\n,\r\n, \n\r, etc) with the line break HTML tag (br)

So your script in the best scenario will strip all line breaks.

]]> By: rossyny http://luci.criosweb.ro/blog/2007/07/24/javascript-nl2br/comment-page-1/#comment-9303 rossyny Thu, 24 Apr 2008 21:35:57 +0000 http://luci.criosweb.ro/blog/?p=51#comment-9303 correct me if I'm wrong - the script works better (at least for me) this way though... "encodeURIComponent" function nl2br(text){ if(encodeURIComponent){ text=encodeURIComponent(text); return decodeURIComponent(text.replace(/(%5Cr%5Cn)|(%5Cn%5Cr)|%5Cr|%5Cn/g,'')); } else{ text=escape(text); return unescape(text.replace(/(%5Cr%5Cn)|(%5Cn%5Cr)|%5Cr|%5Cn/g,'')); } } correct me if I’m wrong – the script works better (at least for me) this way though…
“encodeURIComponent”

function nl2br(text){
if(encodeURIComponent){
text=encodeURIComponent(text);
return decodeURIComponent(text.replace(/(%5Cr%5Cn)|(%5Cn%5Cr)|%5Cr|%5Cn/g,”));
}
else{
text=escape(text);
return unescape(text.replace(/(%5Cr%5Cn)|(%5Cn%5Cr)|%5Cr|%5Cn/g,”));
}
}

]]>